Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LowPriorityImplicits to a com.softwaremill.quicklens to avoid conflicts with other softwaremill libraries #238

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

KacperFKorban
Copy link
Collaborator

closes #237

@KacperFKorban KacperFKorban requested a review from adamw August 12, 2024 16:16
Copy link
Contributor

@slandelle slandelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit.
Thanks!

Copy link
Contributor

@slandelle slandelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It might be cleaner fix the com.softwaremill.quicklens folder into a proper com/softwaremill/quicklens hierarchy.

@adamw adamw merged commit 43e2345 into master Sep 2, 2024
5 checks passed
@adamw
Copy link
Member

adamw commented Sep 2, 2024

Thanks!

@mergify mergify bot deleted the fix-i237 branch September 2, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LowPriorityImplicits is in package com.softwaremill
3 participants